Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(checkstyle): update to version 10.2, update .idea to match #5027

Merged
merged 4 commits into from
Jun 4, 2022

Conversation

keturn
Copy link
Member

@keturn keturn commented May 29, 2022

build(spotbugs): point idea to the config/metrics file

This PR mostly motivated by some minor format change in the checkstyle-idea.xml in recent versions.

But let's use the checkstyle version (10.x) for Java 11 too.

How to test

Check CI for this PR to make sure it didn't lose all its checkstyle findings.

Make sure you can still run Checkstyle in IntelliJ.

build(spotbugs): point idea to the config/metrics file
@keturn keturn added Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels May 29, 2022
@github-actions github-actions bot added the Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. label May 29, 2022
Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI run looks fine (same reports as before), but unfornately I cannot compile or run checkstyle locally right now (also asked on Discord).

@skaldarnar
Copy link
Member

Locally, the tests work fine for me... 🤔

image

@jdrueckert jdrueckert merged commit 114f175 into develop Jun 4, 2022
@jdrueckert jdrueckert deleted the build/checkstyleVersion branch June 4, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants