Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#4908): match IntelliJ and Checkstyle formatting rules #5026

Merged
merged 1 commit into from
May 29, 2022

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented May 29, 2022

Removing final-specific intellij formatting rules - checkstyle does only categorize class (static) variables and instance variables, but not whether they're final or not.

Fixes #4908

@jdrueckert jdrueckert added Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels May 29, 2022
@jdrueckert jdrueckert requested a review from keturn May 29, 2022 17:47
@jdrueckert jdrueckert self-assigned this May 29, 2022
Copy link
Member

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work as intended on the reproduction sample given in the issue. Thanks! 👍

@keturn keturn merged commit 3c61ce7 into develop May 29, 2022
@keturn keturn deleted the chore/4908/match-IJ-checkstyle-formatting-rules branch May 29, 2022 18:39
@jdrueckert
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto-arranging code to satisfy CheckStyle DeclarationOrder
2 participants