Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused ByteCodeReflectFactory #5016

Merged
merged 1 commit into from
May 18, 2022

Conversation

keturn
Copy link
Member

@keturn keturn commented May 17, 2022

The ReflectFactory implementations moved to TeraNUI. This one is no longer referenced.

The ReflectFactory implementations moved to TeraNUI. This one is no longer referenced.
@keturn keturn added Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels May 17, 2022
@keturn keturn requested a review from DarkWeird May 17, 2022 19:22
Copy link
Contributor

@DarkWeird DarkWeird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks logically.
Ok.

Another point:
Why using ReflectFactory? it should be slower at second+ times
EventBus using reflectasm library for generating method accessors..

@keturn keturn merged commit cf4ccb5 into develop May 18, 2022
@keturn keturn deleted the chore/removeReflectFactory branch May 18, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants