fix(ChunkProcessingPipeline): base thread pool size on available processors #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
added
Category: Performance
2 tasks
keturn
force-pushed
the
fix/availableProcessors
branch
from
5513dbe
to
c718ba7
Compare
skaldarnar
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the sort of thing I wanted to fix by moving everything to consistent use of a reactor Scheduler. But it's causing test failures now: the test runner with 1.9 CPUs can't handle running 4 chunk generation threads plus the main loop and the overhead of having them all report to the jacoco monitor.
(it was managing about 2 chunks/second, blocking #5010)
How to test
Play game, see if chunk generation is at least as fast as it was.