fix(SelectionScreen): be more robust in the face of save files with incomplete manifests #5008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4912
Notes for Reviewers
The
mainWorldDisplayName
method I factored out toGameManifest
is very much a "view" type of method, given the way it returns error strings. I'd accept suggestions of other places to put it. Especially if that place had dependency injection support so the caller doesn't have to explicitly pass WorldGeneratorManager.How to test
Edit the
manifest.json
of one of your save files so theworlds
entry is the empty set:"worlds": {},
Start Terasology and go to the game loading screen, make sure that doesn't crash.
Hit the "Details" button, make sure that doesn't crash.
If you proceed to try to actually load the game, that will crash (we can only do so much with a broken save!). Hopefully with a relevant error message.