fix: path quirk on an M1 Mac using Azul JDK 11 #5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cervator
added
Type: Bug
With an implementation that is hopefully robust against differences in working directory.
|
That's weird, but not completely unheard-of. Gradle warns against using I've taken this opportunity to refactor this logic to a new Task class, Can you test the |
|
Both tasks work fine, nice and clean this way, cool 👍 |
keturn
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix Gradle fails to find the templates directory for some reason. Exact same setup (although different JDK 11 I think) on my non-M1 Mac worked fine. Not sure if it is a base issue with M1 Macs or the JDK, but in either case this fixed it.
More issues are piled up beyond this for where there are no arm64 lib variants for the new Apple Silicon chip setup, first one is protobuf, but that's a problem for another day.