refactor: split out chunk work as a seperate helper class #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Refactoring
…efactor/split-chunk-processing-seperate-class engine/src/main/java/org/terasology/engine/rendering/world/RenderableWorldImpl.java
keturn
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Okay, I see, splitting some things up and this:
I moved a lot of stuff out so we don't couple the implementation directly to the context. constructor is looking a lot worse but I rather do that then use the context in its current form.
No argument here. Agree that's a messy constructor, but maybe being explicit with those parameters will help us identify what needs to go where.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so I have a separate object just for managing the chunk meshiness and I moved a lot of stuff out so we don't couple the implementation directly to the context. constructor is looking a lot worse but I rather do that then use the context in its current form.
RenderableWorldImpl at the moment is gluing a lot of systems together not sure how this could be better organized. The way that LOD's are processed in a separate system introduces a lot of complications with control flow.
this is just a continuation of these changes: #4786