Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(server): fix --homedir arg for gradle task server #4916

Merged
merged 1 commit into from
Sep 30, 2021
Merged

build(server): fix --homedir arg for gradle task server #4916

merged 1 commit into from
Sep 30, 2021

Conversation

DarkWeird
Copy link
Contributor

@DarkWeird DarkWeird commented Sep 30, 2021 •
edited
Loading

Contains

Fixes double --homedir arg for gradle server command

How to test

  1. Starts game with gradle server command - server should works

@github-actions github-actions bot added Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Type: Bug Issues reporting and PRs fixing problems labels Sep 30, 2021
jdrueckert
jdrueckert approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out nicely

@jdrueckert jdrueckert merged commit b858dac into develop Sep 30, 2021
@jdrueckert jdrueckert deleted the fix/fix-homedir-for-gradle-server-task branch September 30, 2021 17:02
@DarkWeird DarkWeird mentioned this pull request Nov 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrueckert jdrueckert jdrueckert approved these changes

@keturn keturn Awaiting requested review from keturn

Assignees
No one assigned
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkWeird @jdrueckert