Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update vertex attribute with put(T[] data) #4903

Merged
merged 6 commits into from
Sep 29, 2021
Merged

chore: update vertex attribute with put(T[] data) #4903

merged 6 commits into from
Sep 29, 2021

Conversation

pollend
Copy link
Member

@pollend pollend commented Sep 11, 2021 •
edited
Loading

I added a way to pass in multiple vertices in one pass. should make the API easier to use.

@github-actions github-actions bot added the Type: Chore Request for or implementation of maintenance changes label Sep 11, 2021
@pollend pollend marked this pull request as ready for review September 11, 2021 16:04
@pollend pollend force-pushed the bugfix/add-putall-vertexattribute branch from 6912b6b to c96faa6 Compare September 12, 2021 05:04
@pollend pollend requested a review from keturn September 12, 2021 05:05
@pollend pollend changed the title chore: add vertex attribute putAll chore: update vertex attribute with put(T[] data) Sep 12, 2021
Cervator
Cervator approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say that I know what this does, but as a pure addition it seems safe enough and the tests pass 👍

@Cervator Cervator merged commit b29818b into develop Sep 29, 2021
@Cervator Cervator deleted the bugfix/add-putall-vertexattribute branch September 29, 2021 02:06
@Cervator Cervator added the Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cervator Cervator Cervator approved these changes

@keturn keturn Awaiting requested review from keturn

Assignees
No one assigned
Labels
Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pollend @Cervator