perf: minor adjusments to chunkprocessing pipeline #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace set with List for createMulti - made LightMerger static and migrated instance of Vector3 to Vector3ic - simplify processChunkTasks
pollend
commented
Sep 2, 2021
| if (chunk != null) { | ||
| requiredChunks.add(chunk); | ||
| } else { | ||
| return; |
There was a problem hiding this comment.
we can exit a lot earlier in the evaluation.
pollend
requested review from
naalit,
DarkWeird and
skaldarnar
and removed request for
naalit
naalit
previously approved these changes
Sep 3, 2021
There was a problem hiding this comment.
This looks good to me, I like not creating LightMerger instances all the time and the rest of the changes are pretty straightforward cleanup and improvements. You might want to run "optimize imports" though, there are a lot of checkstyle warnings about unused imports.
naalit
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor adjustments and cleanup to ChunkProcessingPipeline. I tried to clean up some of the intent of these methods a bit and introduced some minor performance adjustments.