Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix debug for skeleton renderer #4863

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

pollend
Copy link
Member

@pollend pollend commented Aug 22, 2021

I corrected the render overlay for skeleton renderer.

issue: #4856

@github-actions github-actions bot added the Type: Bug Issues reporting and PRs fixing problems label Aug 22, 2021
@pollend pollend changed the title bugfix: correct skeleton renderer bugfix: correct skeleton renderer (https://github.com/MovingBlocks/Terasology/pull/4827) Aug 22, 2021
@pollend pollend changed the title bugfix: correct skeleton renderer (https://github.com/MovingBlocks/Terasology/pull/4827) bugfix: correct skeleton renderer (Terasology/4856) Aug 22, 2021
@pollend pollend changed the title bugfix: correct skeleton renderer (Terasology/4856) bugfix: correct skeleton renderer (#4856) Aug 22, 2021
@pollend pollend changed the title bugfix: correct skeleton renderer (#4856) bugfix: correct skeleton renderer (MovingBlocks/Terasology/48634856) Aug 22, 2021
@pollend pollend changed the title bugfix: correct skeleton renderer (MovingBlocks/Terasology/48634856) bugfix: correct skeleton renderer (MovingBlocks/Terasology/4856) Aug 22, 2021
@pollend pollend changed the title bugfix: correct skeleton renderer (MovingBlocks/Terasology/4856) bugfix: correct skeleton renderer (Terasology/4856) Aug 22, 2021
@pollend pollend changed the title bugfix: correct skeleton renderer (Terasology/4856) bugfix: correct skeleton renderer (#4856) Aug 22, 2021
@pollend pollend force-pushed the bugfix/skeletal-renderer-debug-4856 branch from a459bf1 to 2784d93 Compare August 22, 2021 02:13
@pollend pollend changed the title bugfix: correct skeleton renderer (#4856) bugfix: correct skeleton renderer Aug 22, 2021
@pollend pollend changed the title bugfix: correct skeleton renderer bugfix: fix debug for skeleton renderer Aug 23, 2021
@@ -60,11 +57,25 @@
@In
private WorldRenderer worldRenderer;

@In
protected AssetManager assetManager;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks checkstyle analysis 🤓

@skaldarnar skaldarnar added the Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. label Aug 26, 2021
@skaldarnar skaldarnar merged commit 023348d into develop Aug 26, 2021
@skaldarnar skaldarnar deleted the bugfix/skeletal-renderer-debug-4856 branch August 26, 2021 19:46
@keturn keturn added this to the v5.2.0 milestone Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants