Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make render distance for (partially) transparent blocks adjustable #4858

Merged
merged 5 commits into from
Aug 26, 2021

Conversation

naalit
Copy link
Contributor

@naalit naalit commented Aug 19, 2021

Contains

Transparent blocks like leaves and grass are usually invisible beyond a certain distance. This is actually because the game will only render transparent blocks in the closest 64 chunks to the player. This PR disables the limit by default, but it can be re-enabled and the limit changed with a slider in the video settings.

How to test

Look at some trees in the distance, and make sure they still have leaves. Then set the limit to 64 or something and see the difference. I've been testing in Metal Renegades, which might be easier because you can see trees further away.

@github-actions github-actions bot added the Type: Bug Issues reporting and PRs fixing problems label Aug 19, 2021
@keturn keturn requested review from jdrueckert and keturn and removed request for jdrueckert August 23, 2021 01:04
@naalit naalit requested a review from skaldarnar August 23, 2021 17:36
@jdrueckert
Copy link
Member

@tolziplohu there's a few codestyle annotations (in the "Files changed" tab) you might want to check 🙂

@jdrueckert
Copy link
Member

For some reason I was not able to reproduce the leaves not being rendered with the limit set 🤔
Did I misunderstand the PR description? I tried with limit 32 and view distance "Extreme".

@naalit
Copy link
Contributor Author

naalit commented Aug 24, 2021

For some reason I was not able to reproduce the leaves not being rendered with the limit set.

Oh, it turns out that only PlantPack has partially transparent leaves; the leaves in CoreAssets are fully opaque. You can try with Metal Renegades, or just look at grass or flowers.

@skaldarnar skaldarnar added the Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. label Aug 26, 2021
@skaldarnar skaldarnar changed the title fix: render (partially) transparent blocks at any distance feat: make render distance for (partially) transparent blocks adjustable Aug 26, 2021
@skaldarnar skaldarnar merged commit 12ae52e into develop Aug 26, 2021
@skaldarnar skaldarnar deleted the fix/transparent-rendering-distance branch August 26, 2021 18:34
@keturn keturn added this to the v5.2.0 milestone Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants