chore: add maven repo that contains jpastebin #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
keturn
suggested changes
Aug 15, 2021
There was a problem hiding this comment.
I'm reluctant to add to random repositories, but after looking this one up, it seems to me like it would be okay. i.e. it is maintained by someone who is going to keep it online, probably trustworthy to not let random hacks get added to it, and it is intentionally public.
Suggestions:
- add a comment that mentions this is needed for a crashreporter dependency
- add the filter (as seen in the Maven Central repo) that makes sure we don't waste time looking for
org.terasologydependencies in this repository.- copy/pasting that twice (maven & google) is maybe okay. Three gets to be noisy. It would be nice to figure out a better way to configure that.
- alternately, it might be better in this case to filter for only
org:jpastebin
keturn
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required to allow the CrashReporter to import the
org.jpastebindependency which is required to fix the broken CrashReporter integration with PasteBin.See issue #4699
See fix MovingBlocks/CrashReporter#44