-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve performance of mesh generator for chunks #4794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
Request for or implementation of maintenance changes
label
Jun 25, 2021
pollend
commented
Jun 26, 2021
.../src/main/java/org/terasology/engine/rendering/primitives/BlockMeshGeneratorSingleShape.java
Outdated
Show resolved
Hide resolved
pollend
changed the title
chore: minor cleanup for BlockAppearance
perf: improve performance of mesh generator for chunks
Jun 26, 2021
pollend
added
the
Topic: Rendering
Requests, Issues and Changes related to lighting, meshes, camera, etc.
label
Jun 26, 2021
…ngBlocks/Terasology into chore/minor-cleanup-BlockAppearance
pollend
commented
Jun 26, 2021
…re/minor-cleanup-BlockAppearance
skaldarnar
requested changes
Jul 5, 2021
engine/src/main/java/org/terasology/engine/world/block/BlockPart.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/world/block/BlockPart.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/terasology/engine/rendering/primitives/BlockMeshGeneratorSingleShape.java
Show resolved
Hide resolved
.../src/main/java/org/terasology/engine/rendering/primitives/BlockMeshGeneratorSingleShape.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/rendering/primitives/ChunkTessellator.java
Show resolved
Hide resolved
…rt.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
…rt.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
…s/BlockMeshGeneratorSingleShape.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
skaldarnar
requested changes
Jul 10, 2021
…re/minor-cleanup-BlockAppearance
…ngBlocks/Terasology into chore/minor-cleanup-BlockAppearance
@pollend did you check the rest of Omega for any broken code with this? At least in a MetalReneages workspace this does not compile:
|
skaldarnar
pushed a commit
to Terasology/Health
that referenced
this pull request
Aug 18, 2021
…re/minor-cleanup-BlockAppearance
pollend
added a commit
to Terasology/MetalRenegades
that referenced
this pull request
Aug 19, 2021
…ngBlocks/Terasology into chore/minor-cleanup-BlockAppearance
skaldarnar
approved these changes
Aug 19, 2021
skaldarnar
pushed a commit
to Terasology/MetalRenegades
that referenced
this pull request
Aug 19, 2021
skaldarnar
pushed a commit
to Terasology/Health
that referenced
this pull request
Aug 19, 2021
pollend
added a commit
to Terasology/MetalRenegades
that referenced
this pull request
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Topic: Rendering
Requests, Issues and Changes related to lighting, meshes, camera, etc.
Type: Chore
Request for or implementation of maintenance changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some minor performance tweaks to mesh generation. so one bottleneck I found is we evaluate the sides of all the blocks for every block within the chunks so each block will check all its ordinals even if it is lets say its air which has no geometry. API is coupled to the block so mesh information is defined by the block itself. would like this to be more data oriented but that is something to consider later.
I also swapped out the maps for switch cases for BlockParts which should also help to some extent.
hard to test all the permutations so just verifying that chunks render correctly for a couple different types of blocks will be sufficient.