-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(subsystem-prepare): extract Network and R&R code from EventSystemImpl #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or `EventSystem`'s decorators
…into feature/event-system-decomposite
…em-decomposite # Conflicts: # engine-tests/src/test/java/org/terasology/entitySystem/OwnershipHelperTest.java # engine-tests/src/test/java/org/terasology/persistence/ComponentSerializerTest.java
keturn
reviewed
Mar 7, 2021
PerformanceMonitor.startActivity(activity); | ||
} | ||
|
||
//TODO return this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOs and commented code
DarkWeird
approved these changes
Mar 9, 2021
skaldarnar
added
the
Type: Improvement
Request for or addition/enhancement of a feature
label
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Preparement to extraction EntitySystem: extract Network's replication and Recording of R&R from EventSystem.
Used Decorators for compose this together.
How to test
EventSystem loads:
Network:
R&R:
Ref PR: #4323