Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(subsystem-prepare): extract Network and R&R code from EventSystemImpl #4323

Closed
wants to merge 9 commits into from
Closed

feature(subsystem-prepare): extract Network and R&R code from EventSystemImpl #4323

wants to merge 9 commits into from

Conversation

DarkWeird
Copy link
Contributor

@DarkWeird DarkWeird commented Dec 15, 2020 •
edited
Loading

Contains

Preparement to extraction EntitySystem: extract Network's replication and Recording of R&R from EventSystem.
Used Decorators for compose this together.

How to test

EventSystem loads:

  1. Start TS
  2. Create/Load Game
  3. Check that loads and works (movement, windows opens, blocks breaks)

Network:

  1. Start TS
  2. Start server
  3. Join to Server
  4. Check that loads and works (your events should replicated to server)

R&R:

  1. Start TS
  2. Create/Load game
  3. record
  4. replay
  5. check that works.

@DarkWeird DarkWeird added Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Type: Improvement Request for or addition/enhancement of a feature labels Dec 15, 2020
@DarkWeird DarkWeird added this to the v4.2.0 milestone Dec 15, 2020
@skaldarnar skaldarnar modified the milestones: v4.2.0, v4.3.0 Feb 18, 2021
@DarkWeird DarkWeird mentioned this pull request Feb 26, 2021
Open
@DarkWeird
Merge remote-tracking branch 'origin/develop' into feature/event-syst…
31e41b9 
…em-decomposite

# Conflicts:
#	engine-tests/src/test/java/org/terasology/entitySystem/OwnershipHelperTest.java
#	engine-tests/src/test/java/org/terasology/persistence/ComponentSerializerTest.java
@pollend pollend mentioned this pull request Mar 7, 2021
Merged
@pollend pollend closed this Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar Awaiting requested review from skaldarnar

@jdrueckert jdrueckert Awaiting requested review from jdrueckert

Assignees
No one assigned
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkWeird @pollend @skaldarnar