refactor: remove dead code #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
changed the title
jdrueckert
previously approved these changes
Jun 1, 2020
...n/java/org/terasology/persistence/typeHandling/extensionTypes/ComponentClassTypeHandler.java
Outdated
Show resolved
Hide resolved
…xtensionTypes/ComponentClassTypeHandler.java
keturn
reviewed
Jun 2, 2020
Comment on lines
+32
to
+37
| return context.getSandbox().getSubTypeIdentifier(item, Component.class); | ||
| } | ||
|
|
||
| @Override | ||
| public Class<? extends Component> getFromString(String representation) { | ||
| try { | ||
| final Class<? extends Component> clazz = Class.forName(representation).asSubclass(Component.class); | ||
| return clazz; | ||
| } catch (ClassNotFoundException e) { | ||
| e.printStackTrace(); | ||
| return null; | ||
| } | ||
| return context.getSandbox().findSubTypeOf(representation, Component.class).orElse(null); |
There was a problem hiding this comment.
This is the only thing in this PR that's not just a straight deletion. And it looks okay from here.
It does change the constructor, but presumably that's the sort of thing that you'd find out pretty fast as soon as you tried to compile against it.
Actually ... where is this class used? it's not in my workspace.
There was a problem hiding this comment.
Ah, this is actually some sneaky little code cleanup 🤓
This class here existed, but was never used. However, there existed another inner class with exact same name (and purpose) in ComponentClassTypeHandlerFactory. As I don't like inner classes, I thought it would be better to have the correct code in this class, which is now used by the factory.
Cervator
approved these changes
Jun 2, 2020
pollend
approved these changes
Jun 2, 2020
skaldarnar
added
the
Topic: Stabilization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @pollend found out in #3961 there are unused classes and other dead code in the engine.
Tested in Omega workspace, can run Josharias Survival without any (new) issues.