feat(JOML): migrate ChunkViewCore #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
requested changes
Jun 1, 2020
| * A single requested block change. | ||
| * | ||
| */ | ||
| public class BlockUpdate { |
There was a problem hiding this comment.
Do you know what this was used for? I'd rather remove it in a separate PR.
There was a problem hiding this comment.
I've created #4016 to do some code cleanup.
There was a problem hiding this comment.
if you merge the other PR will it matter in regards to this if you can plan to merge this one after? @skaldarnar
Cervator
added
the
Topic: Architecture
|
Looks like the refactoring bit was handled a while ago, tested the rest here and am merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.