Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANIFEST.MF missing ImplementationVersion #2358

Closed
melloware opened this issue May 1, 2023 · 1 comment
Closed

MANIFEST.MF missing ImplementationVersion #2358

melloware opened this issue May 1, 2023 · 1 comment
Labels

Comments

@melloware
Copy link

melloware commented May 1, 2023

Describe the bug
Looking at your Manifest its missing Implementation version.

This means in Java code I cannot detect the Morphia version using dev.morphia.Datastore.class.getPackage().getImplementationVersion() should return 2.3.1 or whatever version of the JAR it is.

Looks like you are missing the Maven JAR plugin to add these default entries.

<plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-jar-plugin</artifactId>
                <configuration>
                    <archive>
                        <manifest>
                            <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                            <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
                        </manifest>
                    </archive>
                </configuration>
            </plugin>
@evanchooly
Copy link
Member

easy enough fix. thanks.

evanchooly added a commit that referenced this issue May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants