Fix an issue when filtering on list of floats with not empty #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagerard
reviewed
Aug 16, 2024
|
|
||
| Family(ages = [7.5, 5.5, 29.5, 32.7]).save() | ||
| Family(ages = []).save() | ||
| assert Family.objects(ages__gt=[]).count() == 1 |
There was a problem hiding this comment.
Further to the comment made in the associated Issue, which one are you expecting to match here? [] or [7.5, 5.5, 29.5, 32.7] ? I believe it's [7.5, 5.5, 29.5, 32.7] but the test case is ambiguous
|
#2828 implements the full support for using list with gt, lt, gte, lte and ne |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when filtering with family.objects(ages__gt=[]) mongoengine raised an error ( This does not happen with list of undeclared fields)
This PR fix this issue.