Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix monitor events #62

Merged
merged 7 commits into from
Oct 10, 2018
Merged

fix monitor events #62

merged 7 commits into from
Oct 10, 2018

Conversation

facundovictor
Copy link
Contributor

@facundovictor facundovictor commented Oct 10, 2018 •
edited
Loading

  • Add missing next token to getNextStackEvents
  • Ensure all child stacks are added to the list of stacks to monitor
  • Fix monitoring to display latest status
  • Move event printing out of spinner to avoid losing multiple simultaneous events.
  • Move the event print to its own function (This will require to adjust the line to the terminal width)
  • Add missing events to the error list to print them in red.

Issue related: #37

@facundovictor facundovictor self-assigned this Oct 10, 2018
grgur
grgur approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@grgur grgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't wait to see this in action

rpigu-i
rpigu-i approved these changes Oct 10, 2018
View reviewed changes
Copy link
Collaborator

@rpigu-i rpigu-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@rpigu-i rpigu-i merged commit 05e2aac into master Oct 10, 2018
@rpigu-i rpigu-i deleted the fix/monitor-events branch October 10, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgur grgur grgur approved these changes

@rpigu-i rpigu-i rpigu-i approved these changes

@theneverstill theneverstill Awaiting requested review from theneverstill

Assignees

@facundovictor facundovictor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@facundovictor @grgur @rpigu-i