Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set drop = TRUE in split.shapviz() #117

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Set drop = TRUE in split.shapviz() #117

merged 2 commits into from
Oct 21, 2023

Conversation

mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Oct 21, 2023

Splitting on an empty factor level does not work with split.shapviz(). Setting drop = TRUE` to fix the problem.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2023

Codecov Report

Merging #117 (d4695a7) into main (3007aae) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d4695a7 differs from pull request most recent head 5458cf6. Consider uploading reports for the commit 5458cf6 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files          11       11           
  Lines         798      798           
=======================================
  Hits          777      777           
  Misses         21       21           
Files Coverage Δ
R/methods.R 97.75% <100.00%> (ø)

@mayer79 mayer79 merged commit 26da111 into main Oct 21, 2023
7 checks passed
@mayer79 mayer79 deleted the drop_levels branch October 21, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants