Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rbind and + methods for mshapviz objects #110

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jmaspons
Copy link
Contributor

No description provided.

@mayer79
Copy link
Collaborator

mayer79 commented Oct 17, 2023

Thx for the contribution. I will check the details later, but I like it.

So far, a "mshapviz" object could indeed include any set of "shapviz" objects, even if column names were different. This was intentional, but I am about to change to a stricter logic: At least all column names should agree upon construction of the "mshapviz" object. This seems reasonable since "mshapviz" objects are typically used for subgroup analyses or multiclass models (or models with identical predictors).

This more strict definition of "mshapviz" will help to simplify certain plots, e.g., the already merged dodged bar plots.

I am working on a different branch on this, and it will help to simplify the checks in your PR.

@mayer79
Copy link
Collaborator

mayer79 commented Oct 18, 2023

Thanks a lot!

@mayer79 mayer79 merged commit fa75551 into ModelOriented:main Oct 18, 2023
7 checks passed
@jmaspons jmaspons deleted the rbind.mshapviz branch October 19, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants