Heptio Auth configuration #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'number': True | ||
| } | ||
| }, | ||
| # 'node_count': { |
There was a problem hiding this comment.
I also suggest to here add link to the issue, that we are waiting to be resolved
There was a problem hiding this comment.
seems there are no link, we have not got api support of cluster resizing
kqueen/engines/eks.py
Outdated
| # TODO define , do we need to use user Arn or Cluster Arn | ||
| # self.cluster.kubeconfig["users"][0]["user"]["exec"]["args"][4] = cluster['cluster']['roleArn'] | ||
| # self.cluster.kubeconfig["users"][0]["user"]["exec"]["args"][4] = cluster['cluster']['arn'] | ||
| # self.cluster.kubeconfig['users'][0]['user']['exec']['args'][4] = cluster['cluster']['roleArn'] |
entrypoint.sh
Outdated
| chmod +x ./heptio-authenticator-aws | ||
| mkdir -p $HOME/bin | ||
| cp ./heptio-authenticator-aws $HOME/bin/heptio-authenticator-aws && export PATH=$HOME/bin:$PATH | ||
| echo 'export PATH=$HOME/bin:$PATH' >> ~/.bashrc |
There was a problem hiding this comment.
I suggest to install aws dependencies in a separate file, so if some fail occurred, exporting variables will work, what do you think?
docs/kqueen.rst
Outdated
| @@ -436,6 +444,13 @@ Provision a Kubernetes cluster using Amazon Elastic Kubernetes Service | |||
| #. Click ``Submit``. | |||
| #. To track the cluster status, navigate to the KQueen main dashboard. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| Currently Kqueen does not support Kubernetes workers-management due Amazon EKS API restrictions, | |||
There was a problem hiding this comment.
Currently, KQueen does not support Kubernetes workers-management because of the Amazon EKS API restrictions. To cover the Kubernetes workers use cases, see Getting started with Amazon EKS <https://docs.aws.amazon.com/eks/latest/userguide/getting-started.html>_
ekhomyakova
reviewed
Jun 19, 2018
kqueen/engines/eks.py
Outdated
| } | ||
| }, | ||
| # 'node_count': { | ||
| # TODO currently unsupported due EKS API restrictions |
There was a problem hiding this comment.
naumvd95
force-pushed
the
kqueen-eks
branch
4 times, most recently
from
ae11810
to
dde6eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kqueen-aws-heptio, Issue in official python k8s-client :
kubernetes-client/python#514
imo it useless to do hardcode (bash scripts/get token inside docker, override k8s-config on the fly) without 'I_WANT_IT_NOW' request?
if we dont hurry, we may wait due issue-resolving
full topic - kubernetes/kubernetes#62185