Move FRW from MAT to MAT-MINERvA #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compiles and I'm able to make plots with good-looking flux systs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes with MAT issue #10 and MAT PR #11.
I've moved these MINERvA-specific flux things, FluxReweighter and FluxSystematics, wholesale here into MAT-MINERVA. Everything compiles, runs, and I reproduce my flux error bars. In that respect, along with MAT PR #11 everything is good to go.
The problem is that in the MAT, FRW was entangled with HistWrappers, being used in HW construction to get special universes and propagate the nue constraint. This seems important, but re-adding that functionality to within MAT-MINERvA has the potential to get messy.
Not going to summarize what I've learned about the problem here in this PR intro.