Various Changes to Michel Reco #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* calculators/LowRecoilPionCuts.h => Her I get the best thetapi for the best pion and I save the information in the member m_bestthetaangle * calculators/WeightFunctions.h => I added the function to get the pion reweight obtained by Mehreen * utilities/LowRecoilPionReco.h => I added the member m_bestthetaangle
…e the Pion Reweight
We need the cluster index in order to fix the double counting between tracked and untracked clusters. Other changes: switch a few hardcoded constants to use PlotUtilsPhysicalConstants. Reorder member variables to better resemble the order that they're initialized. (which is best practice in C++ and can lead to bugs otherwise).
… results were better with the previous version
Pick up the new way to store the tpi-from-michel-range estimator constants.
Bugfix to the new michel systematic.
Due to uncertainty in michel track range from 1.4% uncertainty on detector scintillator mass (per the NSF defaults file).
…inervaExpt/MAT-MINERvA into low_recoil_michels_EverChanges
|
I think it may be time to merge this bad boy into main. @sultamehr, @egranadosvazquez can you please review and comment on the readiness and status of this branch? |
…ion of mehreen tpi weight
I'm making an update to my branch
Also, reformat PionReweighter file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should only impact the people using MAT michels.
We're fiddling with Mehreen's Tpi estimator-from-michel-range and low Tpi weight, adding systematics to them, among other things.