Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params to div, pow, and sqrt #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martinglova
Copy link

@martinglova martinglova commented Feb 1, 2023

Sometimes it's pretty useful to define rounding mode or decimal places per operation without touching global variable (it's like that in other languages as well, ex. Java's BigDecimal).

  1. I am adding a possibility to change rounding mode or decimal places without touching Big.RM or Big.DP for div, pow, and sqrt operations per single usage. This change is non-breaking, it's just enhancement.
  2. I've also simplified mod operation by using new parameters of the div operation.
  3. I've added tests that prove it works as expected and non of the old tests were touched and are passing as before.

Please let me know your feedback @MikeMcl. Thanks in advance.

@martinglova
Copy link
Author

So far I only made changes to .js file. If all is good I'll update .mjs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant