Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Get-WindowsReservedStorageState.md #3831

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

SteveDiAcetis
Copy link
Contributor

@SteveDiAcetis SteveDiAcetis commented Jun 28, 2024

Fixing example, it fails with -Online.

PR Summary

Removed the -Online parameter from the example as it causes error. It doesnt apply per discussion with engineering owner.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

Fixing example, it fails with -Online.
@officedocspr
Copy link
Collaborator

Thanks for submitting your pull request. To improve the quality of your content and make sure all errors are resolved, we recommend that you use the PubOps publishing process.

  1. Add the Sign off label when you think your PR is ready to merge. A PR reviewer either merges it, or adds the Back to Submitter label with a comment about what needs to be fixed and sends it back to you.

  2. If you need to update your content per the PR reviewer feedback, add the Sign off label again.

  3. Your content is published live during one of the next publishing cycles, which are weekdays at 10:30 AM Pacific Time and 3:30 PM Pacific Time.

If you have a question, post it on the Ask an Admin support channel.

@SteveDiAcetis SteveDiAcetis marked this pull request as draft June 28, 2024 19:51
Copy link
Contributor

Learn Build status updates of commit 3f08ba4:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/dism/Get-WindowsReservedStorageState.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@SteveDiAcetis SteveDiAcetis marked this pull request as ready for review June 28, 2024 19:59
@SteveDiAcetis
Copy link
Contributor Author

@mestew not sure if you are able to review and merge this small change. Not urgent.

@mestew
Copy link
Contributor

mestew commented Jul 1, 2024

@SteveDiAcetis Does this bit below need to be pulled out of the cmdlet despcription as well?

  • Gets the current state of reserved storage. This command is supported with the online Windows image.

Thanks for checking out the details on this with engineering. Let me know about the desription and I can get this merged for ya

@SteveDiAcetis
Copy link
Contributor Author

The description is correct. I will add 'only' to it. Because only online, the parameter for online (versus offline image) isn't needed.

Copy link
Contributor

Learn Build status updates of commit 0ef629c:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/dism/Get-WindowsReservedStorageState.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@mestew
Copy link
Contributor

mestew commented Jul 1, 2024

@SteveDiAcetis saw the new change come through. Thanks so much. I'll handle getting this merged in.

@mestew mestew merged commit b6e4b2c into MicrosoftDocs:main Jul 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants