Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the usage of Linux-style paths in 21H1 #455

Closed
wants to merge 1 commit into from

Conversation

grische
Copy link

@grische grische commented Dec 8, 2021

No description provided.

@ghost
Copy link

ghost commented Dec 8, 2021

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ grische sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@opbld33
Copy link

opbld33 commented Dec 8, 2021

Docs Build status updates of commit f2460e6:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/troubleshooting.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mattwojo
Copy link
Collaborator

mattwojo commented Dec 9, 2021

@grische - This looks good, but we're not able to merge until you sign the contributor agreement. If you could sign this -- we will get it merged in. Thanks!

@mattwojo mattwojo self-assigned this Dec 10, 2021
@mattwojo
Copy link
Collaborator

mattwojo commented Jan 4, 2022

Hey @grische - Just another ping to ask that you sign the contributor agreement so I can merge your update into the live docs. If you prefer not to, I can make this update separately - your name just won't be listed as a contributor on the page. Thanks again for contributing! :)

@grische
Copy link
Author

grische commented Jan 4, 2022

@mattwojo I am in the process of trying to get the CLA signed

@mattwojo
Copy link
Collaborator

mattwojo commented Jan 4, 2022

Sounds good. Thanks! Let me know if you get stuck on anything.

@zadjii-msft
Copy link
Contributor

Wait this might not be right - support for linux style paths was added in the Terminal, not Windows. microsoft/terminal#9223

@mattwojo
Copy link
Collaborator

mattwojo commented Jan 4, 2022

@zadjii-msft - so it's incorrect to say: "Beginning in Windows 10 version 21H1" and we should instead say: "As of version 1.12.3472.0, the file systems of WSL distributions is directly referenced and does not need any prefix." >> Is this correct?

It would still be accurate to state the rest below, yes?

You can use /home/<Your Ubuntu Username> to directly refer your home folder. For example, the following setting will launch the "Ubuntu-20.04" distribution in its home file path:

{
    "name": "Ubuntu-20.04",
    "commandline" : "wsl -d Ubuntu-20.04",
    "startingDirectory" : "/home/<Your Ubuntu Username>"
}

@zadjii-msft
Copy link
Contributor

Yep, that's right!

@mattwojo
Copy link
Collaborator

mattwojo commented Jan 8, 2022

Updated the troubleshooting section on this commit: 7cd48bc

Closing this PR. Thanks again for the contribution @grische!

@mattwojo mattwojo closed this Jan 8, 2022
@phil-blain
Copy link
Contributor

Hello, I noticed the Terminal docs still has this "important" note:

> [!IMPORTANT]
> On newer versions of Windows, `startingDirectory` can accept Linux-style paths.

This is confusing because the rest of the text above that note was corrected in 7cd48bc to emphasize that it depends on the Terminal version, and not the Windows version.

Also, 7cd48bc states that support for Linux-style paths was added in Terminal v1.12.3472.0, but it actually goes back to microsoft/terminal@a2a6050, which as GitHub shows us:

    main (#9223) 

    v1.12.3472.0 v1.12.2931.0 v1.12.2922.0 v1.11.3471.0 v1.11.2921.0 v1.11.2731.0 v1.11.2421.0 

was first released in v1.11.2421.0 (Preview) and v1.11.2921.0 (Stable).

@phil-blain
Copy link
Contributor

For cross-reference purpose, here is the version-independent ID:

"e76f9f11-cb0d-95be-7e04-8a9137252e2d"

so that this PR appears in the "All page feedback" link in the live doc.

@phil-blain
Copy link
Contributor

@mattwojo would you be willing to review a PR that would clarify that? :)

@phil-blain
Copy link
Contributor

I clarified that in #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants