Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public PRs #238

Merged
merged 21 commits into from
Feb 8, 2021
Merged

Public PRs #238

merged 21 commits into from
Feb 8, 2021

Conversation

mattwojo
Copy link
Collaborator

@mattwojo mattwojo commented Feb 2, 2021

No description provided.

SamB and others added 13 commits January 28, 2021 16:53
For some reason they were tagged as bash, which broke highlighting in at least one of them.
in line 98 it's `C:\\path\\to\\icon.png` while in line 115 it was `C:\\path\\to\\icon` so I've added the missing `.png`
From #135

* Add icon example and folder location

As originally submitted by @aloneguid in #135

* Remove code brackets for readability

* Add spacing
* Add info about the command palette

1. Add info about the command palette.
2. Typo fixes (e.g. "quick-start guide" instead of "quickstart")
3. Style fix, e.g. we don't have a keyboard key whose full name is "alt+shift+plus".

* revert description

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
* Add a note about hiding dynamic profiles

* Minor writing updates

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
* Clarify adding profile in ssh tutorial. Fixes: #183

* Remove  from docs link
This seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given.
Currently, the install recommends using an out-of-date version of golang, which in turn causes issues while installing powerline-go.
* Add startingDirectory example

* Format startingDirectory entry
@opbld32
Copy link

opbld32 commented Feb 2, 2021

Docs Build status updates of commit 9544259:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/command-palette.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View
TerminalDocs/tutorials/tab-title.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Comment on lines 96 to 101
The icon image file will need to be placed in a location that the Terminal app can read. Place icon images in the Windows Terminal AppData folder, located at: <br>

`%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState`
<br>
<br>
As an example, if you place the icon image `ubuntu.ico` in this folder, the property will be `"icon": "ms-appdata:///roaming/ubuntu.ico"`.
Copy link
Collaborator

@cinnamon-msft cinnamon-msft Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true, icon image files can be anywhere on the machine.

Suggested change
The icon image file will need to be placed in a location that the Terminal app can read. Place icon images in the Windows Terminal AppData folder, located at: <br>
`%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState`
<br>
<br>
As an example, if you place the icon image `ubuntu.ico` in this folder, the property will be `"icon": "ms-appdata:///roaming/ubuntu.ico"`.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we show a couple of different examples that illustrate this to reduce confusion?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed this from a descriptor to an example - how does this look? 65c6d39

Copy link
Collaborator

@cinnamon-msft cinnamon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions that should also make their way back into master once merged.

Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
@opbld32
Copy link

opbld32 commented Feb 3, 2021

Docs Build status updates of commit 82a2f56:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View
TerminalDocs/tutorials/tab-title.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Feb 3, 2021

Docs Build status updates of commit 65c6d39:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View
TerminalDocs/tutorials/tab-title.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
@opbld33
Copy link

opbld33 commented Feb 3, 2021

Docs Build status updates of commit 6090a3e:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View
TerminalDocs/tutorials/tab-title.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
mattwojo and others added 2 commits February 2, 2021 17:48
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
@opbld31
Copy link

opbld31 commented Feb 3, 2021

Docs Build status updates of commit ca0e2ab:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View
TerminalDocs/tutorials/tab-title.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
@opbld31
Copy link

opbld31 commented Feb 3, 2021

Docs Build status updates of commit 214341c:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View
TerminalDocs/tutorials/tab-title.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
@opbld31
Copy link

opbld31 commented Feb 3, 2021

Docs Build status updates of commit 394060f:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View
TerminalDocs/tutorials/tab-title.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Feb 3, 2021

Docs Build status updates of commit 1a2ab63:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View
TerminalDocs/tutorials/tab-title.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -95,8 +93,9 @@ This sets the icon that displays within the tab, dropdown menu, jumplist, and ta

**Accepts:** File location as a string, or an emoji

<br />
**Example:** Placing the icon image `ubuntu.ico` in the folder located at `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState`, you can display the icon by adding this line to the profile in your settings.json: `"icon": "ms-appdata:///roaming/ubuntu.ico"`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Example:** Placing the icon image `ubuntu.ico` in the folder located at `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState`, you can display the icon by adding this line to the profile in your settings.json: `"icon": "ms-appdata:///roaming/ubuntu.ico"`.
**Example:** By placing the icon image `ubuntu.ico` in the folder located at `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState`, you can display the icon by adding this line to the profile in your settings.json: `"icon": "ms-appdata:///roaming/ubuntu.ico"`.

Copy link
Collaborator

@cinnamon-msft cinnamon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one small last nit, but I won't hold an approval for it. :)

@mattwojo
Copy link
Collaborator Author

mattwojo commented Feb 8, 2021

Ok - I mean, I'm kinda all about small nits and would be happy to fix, but I'm just going to merge and then we can fix in the main branch to include in the next push live.

@mattwojo mattwojo merged commit 85519c6 into live Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.