Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create warning directive page #4804

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Rageking8
Copy link
Contributor

Fixes #4703

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit d06be5a:

✅ Validation status: passed

File Status Preview URL Details
docs/preprocessor/hash-error-directive-c-cpp.md ✅Succeeded
docs/preprocessor/hash-warning-directive-c-cpp.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 6f18afe:

✅ Validation status: passed

File Status Preview URL Details
docs/preprocessor/hash-error-directive-c-cpp.md ✅Succeeded
docs/preprocessor/hash-warning-directive-c-cpp.md ✅Succeeded
docs/preprocessor/preprocessor-directives.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit c523295:

✅ Validation status: passed

File Status Preview URL Details
docs/preprocessor/hash-error-directive-c-cpp.md ✅Succeeded
docs/preprocessor/hash-warning-directive-c-cpp.md ✅Succeeded
docs/preprocessor/preprocessor-directives.md ✅Succeeded
docs/preprocessor/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Nov 8, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Nov 8, 2023
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'll hang onto this but won't send it through now because we don't support this directive yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants