Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BrokenLinksH2] Fix path in link #642

Merged
merged 9 commits into from
Jun 9, 2022

Conversation

DhurataJ
Copy link
Contributor

Fixing broken links

@opbld31
Copy link

opbld31 commented May 26, 2022

Docs Build status updates of commit 1887172:

✅ Validation status: passed

File Status Preview URL Details
WindowsCommunityToolkitDocs - Shortcut.lnk ✅Succeeded
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@DhurataJ DhurataJ marked this pull request as ready for review May 26, 2022 20:57
@michael-hawker michael-hawker self-requested a review June 8, 2022 18:24
@michael-hawker
Copy link
Collaborator

Thanks @DhurataJ, taking a look now. Noticed there was an extra WindowsCommunityToolkitDocs - Shortcut.lnk file added though, can we remove that?

@@ -98,7 +98,7 @@ Await MyUIElement.Light(distance:=5, duration:=2500, delay:=250, color:=Colors.R

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually removed this functionality. @Sergio0694 I don't think we have an equivalent yet, eh? We should just put a note at the top or something maybe for now? (I'm hoping we can do an experiment in our new Labs space to replace this in the future, but it's not high on the priority list at the moment.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we don't have light helpers currently. Not entirely sure why we removed them 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was a catch-22 with how we wanted to re-architect the behaviors/media packages or something, and they were the only things remaining that was hard to migrate or something (iirc). The underlying Windows API I believe was deprecated and replaced with something new (but harder to use). So we've had a similar proposal like what we did with Shadows open to resolve it. Something to do in Labs that's been on my list for a while, but just hasn't met the bar yet.

Copy link
Collaborator

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided a few updated links for this.

docs/animations/Fade.md Outdated Show resolved Hide resolved
docs/animations/Fade.md Outdated Show resolved Hide resolved
docs/animations/Offset.md Outdated Show resolved Hide resolved
docs/animations/Rotate.md Outdated Show resolved Hide resolved
docs/animations/Saturation.md Outdated Show resolved Hide resolved
docs/animations/Scale.md Outdated Show resolved Hide resolved
docs/animations/Scale.md Outdated Show resolved Hide resolved
@kturetz kturetz mentioned this pull request Jun 8, 2022
5 tasks
Deleting the  WindowsCommunityToolkitDocs - Shortcut.Ink
@opbld30
Copy link

opbld30 commented Jun 8, 2022

Docs Build status updates of commit 8b74865:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

DhurataJ and others added 7 commits June 8, 2022 17:02
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
@opbld30
Copy link

opbld30 commented Jun 8, 2022

Docs Build status updates of commit 9be40cd:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Jun 8, 2022

Docs Build status updates of commit 352ebab:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Jun 8, 2022

Docs Build status updates of commit 46056e9:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Jun 8, 2022

Docs Build status updates of commit a4fdecb:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Jun 8, 2022

Docs Build status updates of commit 2035f60:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Jun 8, 2022

Docs Build status updates of commit a2b8d83:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Jun 8, 2022

Docs Build status updates of commit f7c6e7c:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@michael-hawker michael-hawker merged commit 9e53a10 into MicrosoftDocs:main Jun 9, 2022
@DhurataJ DhurataJ deleted the wctd-dhj-wb1 branch June 9, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants