Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update T-SQL to be better formatted and also output better-formatted code itself #1573

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

MisterZeus
Copy link
Contributor

Pull request guidance

Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.

We also need your help in order to process your request as soon as possible:

  • We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

  • After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

much T-SQL formatting, both of the code for the 2 stored procedures, and for the T-SQL code they output, to make the resulting login scripts as readable as possible for end-users and SQL Server Admins.
…ns-passwords-between-instances.md

Update transfer-logins-passwords-between-instances.md
@MisterZeus
Copy link
Contributor Author

#sign-off

@MisterZeus
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link

@MisterZeus : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit c5e7ded:

⚠️ Validation status: warnings

File Status Preview URL Details
support/sql/database-engine/security/transfer-logins-passwords-between-instances.md ⚠️Warning Details

support/sql/database-engine/security/transfer-logins-passwords-between-instances.md

  • Line 384, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Swap tabs for 4 spaces as used in original code, unindent Note block as it messed up MSoft's auto format checks.
Copy link
Contributor

Learn Build status updates of commit 1f82489:

✅ Validation status: passed

File Status Preview URL Details
support/sql/database-engine/security/transfer-logins-passwords-between-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

fix code to work for sysname (a.k.a. nvarchar(128)) logins
Copy link
Contributor

Learn Build status updates of commit b7c5ff3:

✅ Validation status: passed

File Status Preview URL Details
support/sql/database-engine/security/transfer-logins-passwords-between-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 18b89dd:

✅ Validation status: passed

File Status Preview URL Details
support/sql/database-engine/security/transfer-logins-passwords-between-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 8daba47:

✅ Validation status: passed

File Status Preview URL Details
support/sql/database-engine/security/transfer-logins-passwords-between-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit b8c06af:

✅ Validation status: passed

File Status Preview URL Details
support/sql/database-engine/security/transfer-logins-passwords-between-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit fc99b2c:

✅ Validation status: passed

File Status Preview URL Details
support/sql/database-engine/security/transfer-logins-passwords-between-instances.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@sevend2 sevend2 merged commit 530a0c5 into MicrosoftDocs:main Sep 6, 2024
2 checks passed
@sevend2
Copy link
Collaborator

sevend2 commented Sep 6, 2024

merge this article as per tech reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants