-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit for clarity #11261
Edit for clarity #11261
Conversation
Learn Build status updates of commit 42bb0df: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
ExpectationsThanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it. To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details. The docs team begins to review your PR if you request them to or if your PR meets these conditions:
You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge. While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST). |
@guillermooo - Thank you so much for this and your other recent submissions! To make reviewing and merging easier, can you combine the changes from #11262 and #11263 into this PR? It would also help if you can pull the changes across every version of the file in the documentation. We have some automation that makes checking whether you've updated all the versioned documentation a bit easier, documented in How to submit pull requests. For quick reference, here's the versioned change report for this PR. When pulling changes across versions, you can use the compare files feature in VS Code, which also works in GitHub CodeSpaces. I'm going to close the other PRs for now. Thank you! |
@michaeltlombardi Do you mean you'd like to see all changes in the same commit or in separate commits in the same PR? |
Reword to improve clarity. Emphasize that changes to preference variables are not global by default.
Use shorter sentences.
reference/5.1/Microsoft.PowerShell.Core/About/about_Preference_Variables.md
Outdated
Show resolved
Hide resolved
Learn Build status updates of commit afea114: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@microsoft-github-policy-service agree |
I personally prefer separate commits, but we squash-merge to main, so they all become a single commit in the repository. I find it easier to review separate commits most of the time, but we don't have a requirement to use atomic commits or anything. Thank you for updating the PR! I'll get it reviewed ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing changes look good - I agree with your assessment of the wording for "automatic confirmation" - happy to merge when that language is updated.
reference/5.1/Microsoft.PowerShell.Core/About/about_Preference_Variables.md
Outdated
Show resolved
Hide resolved
Learn Build status updates of commit 4b0e784: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PR Summary
Reword to improve clarity. Emphasize that changes to preference variables are not global by default.
PR Checklist