Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another 7.4 breaking change with Test-Json - JSON with comments #11244

Conversation

o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Jul 9, 2024

PR Summary

Test-Json has another undocumented breaking change with 7.4: JSON and JSONC with comments. Ref:

I wrote about it. Did not add a ref, as I saw all other refs was to PRs, not issues.

Markdownlint also removed an unused ref.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

Copy link
Contributor

Learn Build status updates of commit 229e978:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/whats-new/What-s-New-in-PowerShell-74.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

@o-l-a-v o-l-a-v force-pushed the 74-breaking-change-test-json-with-comments branch from 229e978 to 9eb4378 Compare July 9, 2024 18:28
Copy link

github-actions bot commented Jul 9, 2024

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

Copy link
Contributor

Learn Build status updates of commit 9eb4378:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/whats-new/What-s-New-in-PowerShell-74.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 71886dc:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/whats-new/What-s-New-in-PowerShell-74.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit f4cda83:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/whats-new/What-s-New-in-PowerShell-74.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler merged commit ed340fb into MicrosoftDocs:main Jul 9, 2024
3 checks passed
@o-l-a-v o-l-a-v deleted the 74-breaking-change-test-json-with-comments branch July 9, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants