Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OrderedDictionary to dynamically create new objects #11090

Merged
merged 11 commits into from
May 9, 2024

Conversation

santisq
Copy link
Contributor

@santisq santisq commented May 9, 2024

PR Summary

This PR explains how to instantiate new custom objects from OrderedDictionary and its the performance benefits.

PR #11084 was closed and making this one from a different branch. Also fixed links to make them relative.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

This comment was marked as outdated.

Copy link

github-actions bot commented May 9, 2024

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and accept my suggested changes.

santisq and others added 3 commits May 9, 2024 17:17
…thoring-considerations.md

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
…thoring-considerations.md

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
…thoring-considerations.md

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>

This comment was marked as outdated.

…thoring-considerations.md

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>

This comment was marked as outdated.

santisq and others added 2 commits May 9, 2024 17:22
…thoring-considerations.md

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
…thoring-considerations.md

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>

This comment was marked as outdated.

This comment was marked as outdated.

@santisq santisq requested a review from sdwheeler May 9, 2024 20:29
Copy link
Contributor Author

@santisq santisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Copy link
Contributor

Learn Build status updates of commit c87bcd5:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/dev-cross-plat/performance/script-authoring-considerations.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler merged commit 4b8cfcc into MicrosoftDocs:main May 9, 2024
3 checks passed
@santisq santisq deleted the ordereddict_perf_considerations branch May 9, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants