Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gentoo PowerShell install/uninstall steps to community-support.md #11060

Closed
wants to merge 1 commit into from

Conversation

xgqt
Copy link

@xgqt xgqt commented Apr 30, 2024

PR Summary

This PR adds Gentoo PowerShell install/uninstall instructions to community-support.md.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@xgqt xgqt force-pushed the 2024-xgqt-add-gentoo-community branch from 1d1b4c3 to 9773b58 Compare April 30, 2024 12:42
@xgqt
Copy link
Author

xgqt commented Apr 30, 2024

@xgqt please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Contributor

Learn Build status updates of commit 1d1b4c3:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/install/community-support.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

Copy link

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

Copy link
Contributor

Learn Build status updates of commit 9773b58:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/install/community-support.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler added the review-shiproom Waiting - for Shiproom discussion label Apr 30, 2024
@sdwheeler
Copy link
Contributor

@xqqt Thanks for the submission. However, given the complexity of maintaining this documentation we don't want to add install instructions for any/every possible Linux distribution to this article.

We could link to instructions in the Gentoo documentation. This is what we did for Arch Linux in this article. If you can provide links to the same kinds of documentation, I would welcome an update to add that information.

@sdwheeler sdwheeler closed this May 7, 2024
@xgqt
Copy link
Author

xgqt commented May 7, 2024

@xqqt Thanks for the submission. However, given the complexity of maintaining this documentation we don't want to add install instructions for any/every possible Linux distribution to this article.

This is extremely disappointing given there are instructions for Kali Linux (... a Ubuntu derivative?).

We could link to instructions in the Gentoo documentation. This is what we did for Arch Linux in this article. If you can provide links to the same kinds of documentation, I would welcome an update to add that information.

I haven't noticed any Arch Linux information but You know, given what burden you think it is, wouldn't also checking out 3rd-party wiki be a pain?

So, summarizing, its better for Gentoo knowledge to stay on the Gentoo Wiki.
Not that its bad, but if Microsoft upstream wants it that way, so be it.

@sdwheeler
Copy link
Contributor

Here is the link to the Arch Linux information in that same article: https://learn.microsoft.com/powershell/scripting/install/community-support#arch-linux.

If there are docs in the Gentoo Wiki that we can link to I would add a section for Gentoo.

@xgqt
Copy link
Author

xgqt commented May 7, 2024

If there are docs in the Gentoo Wiki that we can link to I would add a section for Gentoo.

I have just created https://wiki.gentoo.org/wiki/PowerShell

Do I have to submit a new PR or would You, @sdwheeler take care of adding a reference to it?

@sdwheeler
Copy link
Contributor

@xgqt I can add it. Thanks for the quick Wiki link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-shiproom Waiting - for Shiproom discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants