Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1/17/2024 PM Publish #10805

Merged
merged 4 commits into from
Jan 17, 2024
Merged

1/17/2024 PM Publish #10805

merged 4 commits into from
Jan 17, 2024

Conversation

Taojunshen
Copy link
Contributor

PR Summary

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

mikefrobbins and others added 4 commits January 17, 2024 08:36
@mikefrobbins
Fixes 10796 - Removed invalid parameters (#10800)
fdacfcd 
Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>
@sdwheeler
Remove note about Options for VariableDefinitions (#10802)
dd6931a
@michaeltlombardi
(GH-10801) Fix -OutFile for web request cmdlets (#10804)
7da23e5 
Prior to this change, the documentation for the `-OutFile` parameter
of the `Invoke-WebRequest` cmdlet incorrectly mentioned retrieving
the filename from the Content-Disposition. This functionality isn't
implemented. Further, the `-OutFile` parameter for `Invoke-RestMethod`
is missing any version-specific note, even though the behavior is the
same.

This change:

- Fixes the wording for the `-OutFile` parameter in `Invoke-WebRequest`
  to remove the non-implemented detail.
- Adds a note to the documentation for `Invoke-RestMethod` about the
  automatic naming.
- Resolves #10801
- Fixes AB#200725
@michaeltlombardi
(GH-10798) Clarify how to find exception names in about_Trap (#10803)
ac084bf 
* (MAINT) Fixup grammar & formatting for about_Trap

This change addresses issues raised against the `about_Trap` topic by
Vale, Acrolinx, and the PowerShell docs style guide.

It cleans up the prose, fixes grammar, and standardizes code formatting.

* (GH-10798) Clarify how to find exception names in about_Trap

Prior to this change, the `about_Trap` topic explained how to
use specific exceptions with a `trap` statement, but not how
to discover the exception names for that purpose.

This change:

- Adds prose and example to the section "Trapping specific errors"
  that covers how to get the full name of an exception
- Resolves #10798
- Fixes AB#200723
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit ac084bf:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Trap.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/New-PSSessionConfigurationFile.md ✅Succeeded View (powershell-5.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Trap.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/New-PSSessionConfigurationFile.md ✅Succeeded View (powershell-7.2)
reference/7.3/Microsoft.PowerShell.Core/About/about_Trap.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/New-PSSessionConfigurationFile.md ✅Succeeded View (powershell-7.3)
reference/7.4/Microsoft.PowerShell.Core/About/about_Trap.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/New-PSSessionConfigurationFile.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Utility/Invoke-RestMethod.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Utility/Invoke-WebRequest.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Utility/New-Guid.md ✅Succeeded View (powershell-7.4)

For more details, please refer to the build report.

For any questions, please:

@Taojunshen Taojunshen merged commit c0e855a into live Jan 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdwheeler sdwheeler Awaiting requested review from sdwheeler sdwheeler is a code owner

@michaeltlombardi michaeltlombardi Awaiting requested review from michaeltlombardi michaeltlombardi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Taojunshen @mikefrobbins @sdwheeler @michaeltlombardi