Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvertFrom-Json: Add -DateKind parameter #10737

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Dec 14, 2023

PR Summary

Documents the -DateKind parameter that is part of the

This should not be merged until/if PowerShell/PowerShell#20925 is accepted. There was no 7.5 folder so I'm unsure if that needs to change or not.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the [contributors guide][contrib].
  • Style: This PR adheres to the [style guide][style].

Copy link
Contributor

Learn Build status updates of commit 4b0e51c:

✅ Validation status: passed

File Status Preview URL Details
reference/7.4/Microsoft.PowerShell.Utility/ConvertFrom-Json.md ✅Succeeded View (powershell-7.4)

For more details, please refer to the build report.

For any questions, please:

Copy link

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

@sdwheeler sdwheeler added hold-for-pr Waiting - for PR merge hold-for-release Waiting - for next release labels Dec 14, 2023
@sdwheeler
Copy link
Contributor

@jborean93 Thanks for the update. The change need to be made to the 7.5 content once we create it. I am closing this PR for now. When we have a 7.5 release I will reopen it and ask you to update the PR.

@sdwheeler sdwheeler closed this Jan 2, 2024
@jborean93
Copy link
Contributor Author

Hi @sdwheeler I've rebased the PR and put the changes in the 7.5 directory now that they are there, can this PR be reopened please?

@sdwheeler sdwheeler reopened this Jan 29, 2024
@sdwheeler
Copy link
Contributor

@jborean93 Thanks for the reminder. I have been meaning to reopen this.

This comment was marked as outdated.

@jborean93 jborean93 force-pushed the from-json-datekind branch 2 times, most recently from 94ca185 to ef05a59 Compare January 29, 2024 20:34

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

Learn Build status updates of commit b1b6ff0:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Utility/ConvertFrom-Json.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

@jborean93
Copy link
Contributor Author

Thanks @sdwheeler for the fixes. The PR this is based on PowerShell/PowerShell#20925 has been merged. I've rebased this branch on the latest in main as well. Please let me know if you need anything else from me.

Copy link
Contributor

Learn Build status updates of commit 0f403c2:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Utility/ConvertFrom-Json.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler removed the hold-for-pr Waiting - for PR merge label Feb 13, 2024
Copy link
Contributor

Learn Build status updates of commit b5b88c4:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Utility/ConvertFrom-Json.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler removed the hold-for-release Waiting - for next release label Feb 23, 2024
Copy link
Contributor

Learn Build status updates of commit f781270:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Utility/ConvertFrom-Json.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler merged commit 3b28000 into MicrosoftDocs:main Feb 23, 2024
4 checks passed
@jborean93 jborean93 deleted the from-json-datekind branch February 23, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants