Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11/15/2023 PM Publish #10641

Merged
merged 3 commits into from
Nov 15, 2023
Merged

11/15/2023 PM Publish #10641

merged 3 commits into from
Nov 15, 2023

Conversation

Taojunshen
Copy link
Contributor

PR Summary

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

michaeltlombardi and others added 3 commits November 15, 2023 09:10
@michaeltlombardi
Fix Add-Member examples (#10637)
9e474ea 
Prior to this change, Example 3 in the 7x documentation
for `Add-Member` was incorrect. Example 6 across all
versions rendered incorrectly.

This change:

- Fixes #10633 by correcting the example
- Fixes #10634 by turning the example code blocks into
  a single demonstrative block.
- Fixes Vale linting errors.
@sdwheeler
Fixes #10635 - Define script files as script blocks (#10638)
56fbc29 
* Update references to 7.4 for GA release

* Define script files as script blocks
@sdwheeler
Fix example output diffs for each version (#10639)
1104d74
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 1104d74:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Hash_Tables.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Script_Blocks.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Add-Member.md ✅Succeeded View (powershell-5.1)
reference/5.1/PSReadLine/About/about_PSReadLine.md ✅Succeeded View (powershell-5.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Hash_Tables.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_PowerShell_Editions.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Script_Blocks.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Utility/Add-Member.md ✅Succeeded View (powershell-7.2)
reference/7.2/PSReadLine/About/about_PSReadLine.md ✅Succeeded View (powershell-7.2)
reference/7.3/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Hash_Tables.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_PowerShell_Editions.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Properties.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Script_Blocks.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Utility/Add-Member.md ✅Succeeded View (powershell-7.3)
reference/7.3/PSReadLine/About/about_PSReadLine.md ✅Succeeded View (powershell-7.3)
reference/7.4/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Hash_Tables.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Pipelines.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_PowerShell_Editions.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Pwsh.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Script_Blocks.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/Save-Help.md ✅Succeeded View (powershell-7.4)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@Taojunshen Taojunshen merged commit cad3ad5 into live Nov 15, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdwheeler sdwheeler Awaiting requested review from sdwheeler sdwheeler is a code owner

@michaeltlombardi michaeltlombardi Awaiting requested review from michaeltlombardi michaeltlombardi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taojunshen @michaeltlombardi @sdwheeler