Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(AB-161630) Refactor and extend class docs #10615

Conversation

michaeltlombardi
Copy link
Contributor

@michaeltlombardi michaeltlombardi commented Nov 7, 2023

PR Summary

Prior to this change, the class documentation did not go into sufficient detail for the syntax, definition, and limitations of class members.

This change decomposes the about_Classes documentation into multiple files:

  • about_Classes - overview, basic information, full list of limitations.
  • about_Classes_Properties - Full documentation for defining class properties.
  • about_Classes_Methods - Full documentation for defining class methods.
  • about_Classes_Constructors - Full documentation for defining class constructors.
  • about_Classes_Inheritance - Full documentation for defining classes that inherit from a base class or implement an interface.

This change fixes AB#161630.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Prior to this change, the class documentation did not go into sufficient
detail for the syntax, definition, and limitations of class members.

This change decomposes the `about_Classes` documentation into multiple
files:

- `about_Classes` - overview, basic information, full list of limitations.
- `about_Classes_Properties` - Full documentation for defining class
  properties.
- `about_Classes_Methods` - Full documentation for defining class methods.
- `about_Classes_Constructors` - Full documentation for defining class
  constructors.
- `about_Classes_Inheritance` - Full documentation for defining classes
  that inherit from a base class or implement an interface.

This change fixes AB#161630.
Copy link
Contributor

Learn Build status updates of commit e325ccf:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/About.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Classes.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Classes_Constructors.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Classes_Inheritance.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Classes_Methods.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Classes_Properties.md ✅Succeeded View (powershell-5.1)
reference/7.2/Microsoft.PowerShell.Core/About/About.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Classes.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Classes_Constructors.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Classes_Inheritance.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Classes_Methods.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Classes_Properties.md ✅Succeeded View (powershell-7.2)
reference/7.3/Microsoft.PowerShell.Core/About/About.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Classes.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Classes_Constructors.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Classes_Inheritance.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Classes_Methods.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Classes_Properties.md ✅Succeeded View (powershell-7.3)
reference/7.4/Microsoft.PowerShell.Core/About/About.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Classes.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Classes_Constructors.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Classes_Inheritance.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Classes_Methods.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Classes_Properties.md ✅Succeeded View (powershell-7.4)

For more details, please refer to the build report.

For any questions, please:

@michaeltlombardi michaeltlombardi marked this pull request as ready for review November 10, 2023 18:36
Copy link
Contributor

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@sdwheeler sdwheeler merged commit 0907916 into MicrosoftDocs:main Nov 10, 2023
5 checks passed
@michaeltlombardi michaeltlombardi deleted the ab-161630/main/about-classes-edit branch November 10, 2023 21:39
michaeltlombardi added a commit to michaeltlombardi/PowerShell-Docs that referenced this pull request Jan 23, 2024
In MicrosoftDocs#10615, the section for the `NoRunspaceAfinnity` attribute was
erroneously deleted as part of the reorganization of the
about_Classes article.

This change:

- Adds back the documentation and examples for the `NoRunspaceAffinity`
  to the 7.4 and 7.5 versions of about_Classes, as well as a note about
  the default behavior  in the general limitations section.
- Adds a section and example showing the behavior for corrupted runspaces
  due to class runspace affinity in the 7.2 and 7.3 versions, and updates
  the limitations section.
- Resolves MicrosoftDocs#10818
- Fixes AB#202807
sdwheeler pushed a commit that referenced this pull request Jan 23, 2024
In #10615, the section for the `NoRunspaceAfinnity` attribute was
erroneously deleted as part of the reorganization of the
about_Classes article.

This change:

- Adds back the documentation and examples for the `NoRunspaceAffinity`
  to the 7.4 and 7.5 versions of about_Classes, as well as a note about
  the default behavior  in the general limitations section.
- Adds a section and example showing the behavior for corrupted runspaces
  due to class runspace affinity in the 7.2 and 7.3 versions, and updates
  the limitations section.
- Resolves #10818
- Fixes AB#202807
@Taojunshen Taojunshen mentioned this pull request Jan 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants