-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use correct values for subscriptionKey and endpointKey for qna services #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
February 6, 2019 18:27
With the client already running, run `Electron: Main` debug command in vscode to enable breakpoints in the typescript. NOTE: `npm run build:electron` needs to be done after making any changes to the typescript or else the breakpoints will not work correctly.
a-b-r-o-w-n
force-pushed
the
fix-qna-bot-file
branch
from
February 6, 2019 18:30
0fa675c
to
08dd954
Compare
Pull Request Test Coverage Report for Build 2011
💛 - Coveralls |
@a-b-r-o-w-n - You might be able to cover the continuation in the loop thusly: let success = 100
const mockArgsPassedToFetch = [];
let mockResponses;
jest.mock('node-fetch', () => {
const fetch = (url, headers) => {
mockArgsPassedToFetch.push({ url, headers });
return {
ok: (--success > 0),
json: async () => mockResponses.shift(),
text: async () => mockResponses.shift(),
};
};
(fetch as any).Headers = class {};
(fetch as any).Response = class {};
return fetch;
});
...
it('should skip over responses that do not succeed', () => {
success = 1;
// do stuff
expect(result.services.length).toBe(1);
}); |
@justinwilaby That's a good idea. I have another implementation that I just wrapped up. I'll push it once I see that there is coverage for that line. |
tonyanziano
approved these changes
Feb 6, 2019
"env": { | ||
"NODE_ENV": "development" | ||
"NODE_ENV": "development", | ||
"ELECTRON_TARGET_URL": "http://localhost:3000/" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1286
closes #1287
closes #1289
Fixed