Skip to content
This repository has been archived by the owner on May 2, 2020. It is now read-only.

fix needed for some machine configurations #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

montyvesselinov
Copy link

This fix needed for some machines.

@MichaelHatherly
Copy link
Owner

Thanks. This can probably just be a VERSION comparison now since this was added prior to the commit that deprecated isgeneric. Something like

if VERSION >= v"0.5.0-dev+2396"
    _isgeneric(x) = true
else
    _isgeneric(x) = isgeneric(x)
end

should do the trick now.

(There's probably some more serious breakages in Julia 0.5-dev for Docile and Lexicon though, but since both are being deprecated in favour of https://github.com/MichaelHatherly/Documenter.jl fixing them hasn't been able to be high on the list of priorities currently.)

@montyvesselinov
Copy link
Author

Actually this occurred with version 0.4.5. I do not know why.
On Tue, May 24, 2016 at 2:01 AM Michael Hatherly notifications@github.com
wrote:

Thanks. This can probably just be a VERSION comparison now since this was
added prior to the commit that deprecated isgeneric. Something like

if VERSION >= v"0.5.0-dev+2396"
_isgeneric(x) = trueelse
_isgeneric(x) = isgeneric(x)end

should do the trick now.

(There's probably some more serious breakages in Julia 0.5-dev for Docile
and Lexicon though, but since both are being deprecated in favour of
https://github.com/MichaelHatherly/Documenter.jl fixing them hasn't been
able to be high on the list of priorities currently.)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#136 (comment)

-monty

@MichaelHatherly
Copy link
Owner

Actually this occurred with version 0.4.5. I do not know why.

Probably due to Base.find_source_file returning nothing when it can't find the file, which could happen with non-source builds maybe.

The version check is the right way to do this though and should work correctly everywhere.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants