Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordlist Portuguese Brazil BIP39 #385

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

alissonsolitto
Copy link
Contributor

Implementation of the list of words in the Portuguese-Brazilian language.
The word list was obtained at this link:

Issue: bitpay/bitcore-mnemonic#52
WordList: https://github.com/bitpay/bitcore-mnemonic/files/559361/brazilian_english.js.zip

Credits for the word list: https://github.com/eddieoz

@NicolasDorier
Copy link
Collaborator

Nice!

@NicolasDorier NicolasDorier merged commit 5e276cd into MetacoSA:master Apr 7, 2018
@johnnyasantoss
Copy link

johnnyasantoss commented Jun 11, 2021

The list created by @eddieoz isn't the one set by the BIP39 (see bitcoin/bips#998). Actually, at the time that this PR was merged, there wasn't any pt-BR lists that were approved by the BIP39 proposal.

I just hope no one used this word list.

EDIT: the issue (bitpay/bitcore-mnemonic#52 that should have been an PR) was never merged/done.

@alissonsolitto
Copy link
Contributor Author

@johnnyasantoss

Very well pointed out, I stayed out of the crypt world until then.

@johnnyasantoss
Copy link

Well, let's get this fixed. I'm just not sure how it would be the transition process from one word list to another. Maybe a program that exchanges the words based on their index, but that might not be the best ux.

@NicolasDorier
Copy link
Collaborator

wow ok I will use the new version

@NicolasDorier
Copy link
Collaborator

@johnnyasantoss I replace the old list with the new one. What I can do if somebody need it is to keep the old list and call it "legacy". Then end wallet can just check the current wordlist, and if checksum fail, try to fallback on the legacy one.

@johnnyasantoss
Copy link

@NicolasDorier great! I'll be looking out for other bitcoin libs to check if they also have the non-standard wordlist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants