Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Starknet Snap docs #1509
base: main
Are you sure you want to change the base?
WIP: Starknet Snap docs #1509
Changes from all commits
e6bd15c
f8c3685
1130adf
9401571
a43f196
c27a96d
6bac10a
473a71d
25821bb
0251bcc
3d8ef91
b915696
5b6e1cf
f2074ef
455aaec
d832af8
df73570
0e4ef69
8e75cb8
8501a8b
baa2b16
f6f30a2
81d3bb2
c5f1762
333cef5
5786849
8e467fa
151e759
a1fe114
ff7df58
faba7f4
1617eab
4a64f9b
07ad89e
0cadd60
d432e98
99839e7
f92fdc3
cc4cb52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaniefromtheblock
attached the diagram for the Architecture
feel free to move it to anywhere you prefer or even change the content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WalletAccount is design for get-starknet v4, which we have not integrated yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khanti42 so I should remove all instances and mentions of
WalletAccount
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, the fact is,
in get-starknet 3.3.0, user will communicate with network via SWO.account
in get-starknet 4.x user can communicate with network via SWO.account or make their own implementation with WalletAccount object
and we will try to do the advice comment on all
WalletAccount
related comment , including the description , and you can help us to revised to better wording later, wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stanleyyconsensys Sorry that's not a typo. The markdown will increment. If you check the Vercel build it will show sequential numbering. I just chose to do it like that in case we add or remove another step - that way we will not have to renumber everything ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WalletAccount is design for get-starknet v4, which we have not integrated yet
for current implementation, it works as above way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Starknet there is a difference between creating a wallet account object and deploying an account. The creation of the walletObject is handled by the snap. The Deployment of the account (that targets the network) is done during the first transaction if the account is not deployed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combine with @khanti42 comments, i have make a advice change above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating and providing more guidance on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need a if / else close.
if the account is not deployed then the account deployment is done together with the write transaction. If the account is already deployed then only the transaction is written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if the last open point is valid or not (
get-starknet
can also request MetaMask to display specific tokens...),if it means fetch token balance , then it is ,
if it means display token in MM wallet, then it is not