Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't blow away package manifest when updating #20

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Commits on Aug 17, 2022

  1. Don't blow away package manifest when updating

    When we read a package manifest, we need a representation of the
    manifest that we can make reliable assumptions about. To do this, we
    disregard fields that we don't care about and we fill in default values
    for fields that we _do_ care about but haven't been explicitly provided.
    
    The problem is that when updating the version of a package, we are using
    a modified version of this representation of the manifest. That isn't
    good, because it means that the package's manifest ends up getting
    fundamentally changed.
    
    This commit fixes this by storing the original representation of the
    manifest when it is read. This representation is then used when the
    version is updated instead of the "parsed" representation. This does
    make the parsed representation immediately out of date, but that doesn't
    really matter.
    mcmire committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    e8ccf1a View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Configuration menu
    Copy the full SHA
    3154722 View commit details
    Browse the repository at this point in the history