test(fix for #266): check resolved #266

Met4FoF · Feb 3, 2022 · 465858b · 465858b
1 parent 08f769c
commit 465858b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/agentMET4FOF/network.py b/agentMET4FOF/network.py
@@ -172,7 +172,7 @@ def generate_module_name_byUnique(self, agent_name: str) -> str:
 
         def add_agent(
             self,
-            name: Optional[str] = " ",
+            name: Optional[str] = None,
             agentType: Optional[Type[AgentMET4FOF]] = AgentMET4FOF,
             log_mode: Optional[bool] = True,
             buffer_size: Optional[int] = 1000,
@@ -184,7 +184,7 @@ def add_agent(
                 if ip_addr is None:
                     ip_addr = "0.0.0.0"
 
-                if name == " ":
+                if name is None:
                     new_name = self.generate_module_name_byType(agentType)
                 else:
                     new_name = self.generate_module_name_byUnique(name)
@@ -215,7 +215,7 @@ def add_agent(
 
         def _add_osbrain_agent(
             self,
-            name: Optional[str] = " ",
+            name: Optional[str] = None,
             agentType: Optional[Type[AgentMET4FOF]] = AgentMET4FOF,
             log_mode: Optional[bool] = True,
             buffer_size: Optional[int] = 1000,
@@ -239,7 +239,7 @@ def _add_osbrain_agent(
 
         def _add_mesa_agent(
             self,
-            name: Optional[str] = " ",
+            name: Optional[str] = None,
             agentType: Optional[Type[AgentMET4FOF]] = AgentMET4FOF,
             log_mode: Optional[bool] = True,
             buffer_size: Optional[int] = 1000,
@@ -939,7 +939,7 @@ def generate_module_name_byType(self, agentType):
 
     def add_agent(
         self,
-        name: Optional[str] = " ",
+        name: Optional[str] = None,
         agentType: Optional[Type[AgentMET4FOF]] = AgentMET4FOF,
         log_mode: Optional[bool] = True,
         buffer_size: Optional[int] = 1000,

diff --git a/tests/test_naming_monitor_agents.py b/tests/test_naming_monitor_agents.py
@@ -37,3 +37,12 @@ def test_naming_agents_for_osbrain(agent_network):
         == agent.get_attr("name")
         == random_name.replace(" ", "_")
     )
+
+
+def test_naming_a_mesa_agents_with_a_single_space():
+    agent_network = AgentNetwork(dashboard_modules=False, backend=Backend.MESA)
+
+    agent = agent_network.add_agent(name=" ", agentType=AgentMET4FOF)
+    assert agent_network.get_agent("_").name == agent.name == "_"
+
+    agent_network.shutdown()