Fix nushell with --nom, make shell bits templated #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nu template uses the executable very differently from others, so it ends up trying weird things like `which nix-your-shell --nom`, which fails because `which` doesn't understand `--nom`. The other shell templates are also broken as shell _scripts_, because they rely on the `nix-your-shell` -> `nix-your-shell $shell` substitution. Fix everything by using a real template engine.
github-actions
bot
added
the
patch
|
sickos yes |
|
Tested this locally, looks good! |
|
$5 if you can tell me why the 'update versions and push a release PR' job failed lmao https://github.com/MercuryTechnologies/nix-your-shell/actions/runs/8330184312/job/22799988945 |
|
Sorry, I know absolutely nothing about Github actions :( |
|
OK I got the release pipeline fixed, tagged here https://github.com/MercuryTechnologies/nix-your-shell/releases/tag/v1.4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nu template uses the executable very differently from others, so it ends up trying weird things like
which nix-your-shell --nom, which fails becausewhichdoesn't understand--nom.The other shell templates are also broken as shell scripts, because they rely on the
nix-your-shell->nix-your-shell $shellsubstitution.Fix everything by using a real template engine.