Add option to force specifying pool name #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
force-pushed
the
force-pool-name
branch
from
e491d95
to
4ad1137
Compare
pkg/cni/types/types.go
Outdated
| @@ -148,9 +151,13 @@ func (cl *confLoader) LoadConf(args *skel.CmdArgs) (*NetConf, error) { | |||
| } | |||
|
|
|||
| // overlay config with defaults | |||
| var defaultPoolName string | |||
| if !fileConf.ForcePoolName { | |||
There was a problem hiding this comment.
I think we should not limit this to the fileConf. We should support this option as STDIN ARG also.
in some cases it is desired to make specifying at least one pool in poolName or pools mandatory. To achieve this we add a new IPAM CNI parameter which can be defined in nv-ipam config file. this will prevent CNI from using network name as pool name in case poolName was not specified. Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
force-pool-name
branch
from
4ad1137
to
52b3daa
Compare
rollandf
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some cases it is desired to make specifying at least one pool in poolName or pools mandatory. To achieve this we add a new IPAM CNI parameter which can be defined in nv-ipam config file. this will prevent CNI from using network name as pool name in case poolName was not specified.