Add local dev env via skaffold #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adrianchiris
commented
Aug 15, 2023
adrianchiris
commented
- create new dev overlay
- create skaffold yaml
- add tasks to create/clean local k8s dev env
- update README
adrianchiris
force-pushed
the
add-skaffold-support
branch
from
1771081
to
8eb513f
Compare
ykulazhenkov
approved these changes
Aug 16, 2023
taskfiles/LocalDev.yaml
Outdated
| # that way skaffold will build images in the correct local repo. | ||
| eval $(minikube -p nfd-dev docker-env) | ||
| kubectl apply -k "https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref={{.NFD_VERSION}}" | ||
| skaffold dev |
There was a problem hiding this comment.
nit: maybe it will better to use --trigger=manual to avoid unneeded rebuilds?
- create new dev overlay - create skaffold yaml - add tasks to create/clean local k8s dev env - update README Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
add-skaffold-support
branch
from
8eb513f
to
4973441
Compare
Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
add-skaffold-support
branch
from
43797b8
to
aa28dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.